Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various fs support #267

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix: various fs support #267

merged 2 commits into from
Nov 21, 2023

Conversation

guybedford
Copy link
Collaborator

@guybedford guybedford commented Nov 21, 2023 •
edited
Loading

This gets the test coverage from 27 -> 33 tests passing, implementing more of the fs functionality.

One of the tests involved an upstream change - bytecodealliance/wasmtime#7563, which we can potentially change this side to support the expected behaviour with an error handler of the form:

if (e.code === "ENOENT") {
  if (openFlags.directory)
    throw "not-directory";
  else
    throw 'loop';
  }
}

@guybedford guybedford added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit 1a9e5cd Nov 21, 2023
6 checks passed
@guybedford guybedford deleted the fs-work branch November 21, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@guybedford